[CoroutineAccessors] Add read and modify. #2853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
reviewed
Sep 17, 2024
| @@ -628,6 +632,8 @@ public enum Keyword: CaseIterable { | |||
| return KeywordSpec("protocol", isLexerClassified: true) | |||
| case .public: | |||
| return KeywordSpec("public", isLexerClassified: true) | |||
| case .read: | |||
| return KeywordSpec("read") | |||
There was a problem hiding this comment.
Should read also be behind an experimental feature, like modify?
There was a problem hiding this comment.
Thanks! Fixed.
| """, | ||
| experimentalFeatures: .coroutineAccessors | ||
| ) | ||
| } |
There was a problem hiding this comment.
Could you also add a test case that read and modify are not parsed when the .coroutineAccessors experimental features is not specified?
There was a problem hiding this comment.
Yep--added one for each.
|
Accidentally opened this PR from a branch in this repo rather than my fork. Closing in favor of the one from my fork: #2855 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable parsing the new keywords behind the CoroutineAccessors experimental feature.