[CoroutineAccessors] Initial framing. #76526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
general-coro/20240906/1
branch
3 times, most recently
from
467955f to
7b7a741
Compare
nate-chandler
force-pushed
the
general-coro/20240906/1
branch
2 times, most recently
from
7df685e to
e37fe1c
Compare
nate-chandler
force-pushed
the
general-coro/20240906/1
branch
from
e37fe1c to
02c06eb
Compare
And replaced direct comparisons with calls to predicates. In preparation for introducing parallel non-underscored accessors.
To the routine that parses the introducer for an accessor whether it is would be first accessor, pass whether it would be the first accessor; from it, return whether the accessor is from an unavailable feature. These both enable expected behavior when an experimental feature is disabled: the former enables maintaining source compatibility with code that uses the introducer name as a function name which is called with a trailing closure as the first expression in an implicit getter. The latter enables suppressing duplicative diagnostics.
It was once used for materializeForSet.
Enable customizing the behavior of macro expansions of for accessors which are experimental coroutines.
Don't bother saving the previous ExcludeAttrList's size and restoring it after execution when that list isn't modified.
And move a couple of StorageImplInfo member functions into it. In preparation for making them use an ASTContext, to avoid importing that header into StorageImpl.h, a lightweight header.
nate-chandler
force-pushed
the
general-coro/20240906/1
branch
from
02c06eb to
30f2c3c
Compare
In preparation to introduce more calls.
Make use of swift::getAccessorNameForDiagnostic instead of having a parallel list of accessor names in DiagnosticsSema.def.
nate-chandler
force-pushed
the
general-coro/20240906/1
branch
from
30f2c3c to
3c1361c
Compare
Refer to the correct problematic accessor or accessors.
The name is a placeholder for the mutating single-yield coroutine accessor.
The name is a placeholder for the mutating single-yield coroutine accessor.
nate-chandler
force-pushed
the
general-coro/20240906/1
branch
from
3c1361c to
091368b
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test linux platform |
nate-chandler
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin,
jckarter,
CodaFi,
DougGregor,
rjmccall,
mikeash,
al45tair,
xymus,
AnthonyLatsis,
eeckstein,
adrian-prantl and
tshortli
as code owners
ahoppen
reviewed
Sep 27, 2024
| @@ -7861,7 +7861,9 @@ static bool isAllowedWhenParsingLimitedSyntax(AccessorKind kind, bool forSIL) { | |||
| case AccessorKind::WillSet: | |||
| case AccessorKind::DidSet: | |||
| case AccessorKind::Read: | |||
| case AccessorKind::Read2: | |||
There was a problem hiding this comment.
Would it make sense to have more descriptive names here than Read2? For example, rename the exiting Read to UnderscoreRead and then use Read for Read2.
There was a problem hiding this comment.
I think Read2 and Modify2 are fine placeholders for now until the final names are decided on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial steps towards
readandmodify. Add a new feature flag. Behind it, allow parsing the keywords. Add mangling for these symbols. For now, they are emitted just like_readand_modify.