[Diagnostics] Fix and adjust FixIt application #2941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#78670 |
rintaro
force-pushed
the
swiftdiags-replace-trivia
branch
2 times, most recently
from
122e9bc to
6cb2779
Compare
ahoppen
approved these changes
Jan 16, 2025
| @@ -36,6 +36,7 @@ public enum FixItApplier { | |||
| ) -> String { | |||
| let messages = messages ?? diagnostics.compactMap { $0.fixIts.first?.message.message } | |||
|
|
|||
| // FIXME: This assumes every fix-it is applied to a node in the 'tree', which is not guaranteed. | |||
There was a problem hiding this comment.
Could we check this and ignore Fix-Its that apply to different trees? Although I do worry that macro authors will have made Fix-Its that apply to modified trees and that we might break them with this…
|
swiftlang/swift#78670 |
|
swiftlang/swift#78670 |
* Fix mismatch on 'FixIt.Change.replace' between several application
implementations. Specifically '.replace' should includes the trivia.
* Ignore no-op 'FixIt.Change.replace{Leading|Trailing}Triviia'.
rintaro
force-pushed
the
swiftdiags-replace-trivia
branch
from
6cb2779 to
edde9b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixIt.Change.replacebetween several application implementations. Specifically.replaceshould includes the trivia.FixIt.Change.replace{Leading|Trailing}Triviia.