[ASTGen/MacroEvaluation] Fix and adjust FixIt application #78670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
CodaFi and
hamishknight
as code owners
|
swiftlang/swift-syntax#2941 |
* Fix mismatch on 'FixIt.Change.replace' between several application
implementations. Specifically '.replace' should includes the trivia.
* Ignore no-op 'FixIt.Change.replace{Leading|Trailing}Triviia'.
rintaro
force-pushed
the
swiftdiags-replace-trivia
branch
from
08bc2f0 to
f3329b3
Compare
|
swiftlang/swift-syntax#2941 |
|
swiftlang/swift-syntax#2941 |
1 similar comment
|
swiftlang/swift-syntax#2941 |
|
swiftlang/swift-syntax#2941 |
1 similar comment
|
swiftlang/swift-syntax#2941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixIt.Change.replacebetween several application implementations. Specifically.replaceshould includes the trivia.FixIt.Change.replace{Leading|Trailing}Triviia.