Skip to content

Remove expressible as syntax token #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Nov 27, 2021

Depends on #339

@kimdv kimdv changed the title Kimdv/remove expressible as syntax token remove expressible as syntax token Nov 27, 2021
@kimdv kimdv changed the title remove expressible as syntax token Remove expressible as syntax token Nov 27, 2021
@kimdv kimdv force-pushed the kimdv/remove-expressible-as-syntax-token branch 2 times, most recently from b951db5 to 21d78c8 Compare November 27, 2021 22:51
@ahoppen
Copy link
Member

ahoppen commented Nov 29, 2021

@swift-ci Please test

@kimdv kimdv marked this pull request as ready for review November 29, 2021 11:07
@kimdv kimdv force-pushed the kimdv/remove-expressible-as-syntax-token branch 2 times, most recently from 0096720 to 7da9efb Compare November 29, 2021 17:52
@kimdv
Copy link
Contributor Author

kimdv commented Nov 29, 2021

@swift-ci Please test

@kimdv kimdv force-pushed the kimdv/remove-expressible-as-syntax-token branch 2 times, most recently from 4f1bfdb to 988b5cd Compare November 29, 2021 19:17
@kimdv kimdv force-pushed the kimdv/remove-expressible-as-syntax-token branch 3 times, most recently from 3c1afa5 to b0beb45 Compare November 29, 2021 19:56
@kimdv kimdv force-pushed the kimdv/remove-expressible-as-syntax-token branch from b0beb45 to 04caf99 Compare November 30, 2021 11:38
@kimdv kimdv requested a review from ahoppen November 30, 2021 11:38
@kimdv
Copy link
Contributor Author

kimdv commented Dec 1, 2021

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for a comment, otherwise looking good.

@ahoppen
Copy link
Member

ahoppen commented Dec 1, 2021

🎉 CI testing is honoring your requests, @kimdv 🎉

@kimdv kimdv force-pushed the kimdv/remove-expressible-as-syntax-token branch from 04caf99 to 487aa08 Compare December 1, 2021 16:55
@kimdv
Copy link
Contributor Author

kimdv commented Dec 1, 2021

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Dec 1, 2021

Build failed
Swift Test Linux Platform
Git Sha - 04caf99

@swift-ci
Copy link
Contributor

swift-ci commented Dec 1, 2021

Build failed
Swift Test OS X Platform
Git Sha - 04caf99

@kimdv
Copy link
Contributor Author

kimdv commented Dec 1, 2021

@ahoppen I have added the comment and triggered the CI.
I assume that I can merge, now that you have approved it?

If not, sorry. Please tell then!

@kimdv kimdv merged commit f17a5b5 into swiftlang:main Dec 1, 2021
@kimdv kimdv deleted the kimdv/remove-expressible-as-syntax-token branch December 1, 2021 18:39
@ahoppen
Copy link
Member

ahoppen commented Dec 1, 2021

Yes, if CI passes and you’ve got approval, you may merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants