Add convenience initializer for BinaryOperatorExpr
#344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/add-convenience-initializer-for-binary-operator-expr
branch
5 times, most recently
from
5fbdf7c to
bb72607
Compare
kimdv
changed the title
BinaryOperatorExpr
kimdv
force-pushed
the
kimdv/add-convenience-initializer-for-binary-operator-expr
branch
2 times, most recently
from
4fa7cca to
43692af
Compare
ahoppen
reviewed
Nov 30, 2021
| } | ||
| } | ||
|
|
||
| extension BinaryOperatorExpr: ExpressibleByStringLiteral { |
There was a problem hiding this comment.
Do we actually need the ExpressibleByStringLiteral conformance? IIUC we should be able to use Strings for binary operators in all relevant places because we have String: ExpressibleAsBinaryOperatorExpr.
kimdv
force-pushed
the
kimdv/add-convenience-initializer-for-binary-operator-expr
branch
from
43692af to
0c05205
Compare
kimdv
force-pushed
the
kimdv/add-convenience-initializer-for-binary-operator-expr
branch
from
0c05205 to
a6f06ed
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Dec 1, 2021
kimdv
deleted the
kimdv/add-convenience-initializer-for-binary-operator-expr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#40355
Depends on #343