Improvements in FunctionCallExpr convenience initializer
#452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
May 30, 2022
| @@ -31,4 +31,22 @@ extension FunctionCallExpr { | |||
| additionalTrailingClosures: additionalTrailingClosuresBuilder() | |||
| ) | |||
| } | |||
|
|
|||
| public init( | |||
There was a problem hiding this comment.
I think it would be more general if we changed the ExpressibleAsIdentifierExpr above into ExpressibleByExprBuildable in the convenience initializer above instead of adding another overload.
* Default values for left/right paren arguments * `calledExpression` accepts `ExpressibleAsExprBuildable`, so `MemberAccessExpr` could be passed as well as `IdentifierExpr` * Tests and usages are updated/simplified
evnik
changed the title
FunctionCallExpr convenience initializersFunctionCallExpr convenience initializer
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calledExpressionacceptsExpressibleAsExprBuildable, soMemberAccessExprcould be passed as well asIdentifierExpr