Generate ExpressibleAsProtocols with SwiftSyntaxBuilderGeneration
#495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
force-pushed
the
expressible-as-protocols-swift-syntax-gen
branch
from
c8e8ec2 to
dd88ae4
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Jul 14, 2022
fwcd
force-pushed
the
expressible-as-protocols-swift-syntax-gen
branch
from
dd88ae4 to
5966e6a
Compare
|
@swift-ci please test |
- Stub out ExpressibleAsProtocolsFile - Declare protocols - Add conformance extensions - Remove `ExpressibleAsProtocols.swift.gyb`
fwcd
force-pushed
the
expressible-as-protocols-swift-syntax-gen
branch
from
5966e6a to
4076458
Compare
fwcd
commented
Jul 14, 2022
| let expressibleAsTypes = | ||
| SYNTAX_BASE_KINDS | ||
| .filter { $0 != "SyntaxCollection" } | ||
| .sorted() // Make sure that the order is deterministic |
There was a problem hiding this comment.
I have added a sort here to make the order deterministic (see also #498 (comment)).
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the currently gyb-generated
ExpressibleAsProtocolstoSwiftSyntaxBuilder's DSL as part of the ongoing effort to bootstrapSwiftSyntaxBuilderwithSwiftSyntaxBuilderGeneration.