Generate BuildableBaseProtocols with SwiftSyntaxBuilderGeneration
#498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Jul 11, 2022
Sources/SwiftSyntaxBuilderGeneration/Templates/BuildableBaseProtocolsFile.swift
Show resolved
Hide resolved
Sources/SwiftSyntaxBuilderGeneration/Templates/BuildableBaseProtocolsFile.swift
Outdated
Show resolved
Hide resolved
fwcd
force-pushed
the
buildable-base-protocols-swift-syntax-gen
branch
from
acc5861 to
b9bd02b
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Jul 14, 2022
Sources/SwiftSyntaxBuilderGeneration/Templates/BuildableBaseProtocolsFile.swift
Show resolved
Hide resolved
Sources/SwiftSyntaxBuilderGeneration/Templates/BuildableBaseProtocolsFile.swift
Outdated
Show resolved
Hide resolved
fwcd
commented
Jul 14, 2022
Sources/SwiftSyntaxBuilderGeneration/Templates/BuildableBaseProtocolsFile.swift
Outdated
Show resolved
Hide resolved
fwcd
force-pushed
the
buildable-base-protocols-swift-syntax-gen
branch
from
b9bd02b to
f5ccbf1
Compare
|
@swift-ci please test |
evnik
reviewed
Jul 14, 2022
Sources/SwiftSyntaxBuilder/generated/BuildableBaseProtocols.swift
Outdated
Show resolved
Hide resolved
fwcd
force-pushed
the
buildable-base-protocols-swift-syntax-gen
branch
from
f5ccbf1 to
c5e3d3f
Compare
|
@swift-ci please test |
evnik
reviewed
Jul 16, 2022
Sources/SwiftSyntaxBuilder/generated/BuildableBaseProtocols.swift
Outdated
Show resolved
Hide resolved
- Stub out BuildableBaseProtocolsFile - Generate buildable protocols too - Generate default implementations in BuildableBaseProtocols - Generate rest of BuildableBaseProtocols - Remove gyb-generated BuildableBaseProtocols
fwcd
force-pushed
the
buildable-base-protocols-swift-syntax-gen
branch
from
c5e3d3f to
2e9dc11
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #497.
This PR ports the currently gyb-generated
BuildableBaseProtocolstoSwiftSyntaxBuilder's DSL as part of the ongoing effort to bootstrapSwiftSyntaxBuilderwithSwiftSyntaxBuilderGeneration.