Skip to content

Split token and layout specific methods to specific views #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2022
Merged

Split token and layout specific methods to specific views #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
44e2b06
Split RawSyntax.swift into token-specific, layout-specific and genera…
ahoppen Aug 18, 2022
ee2eebc
Remove legacy methods from RawSyntax
ahoppen Aug 18, 2022
5baa961
Move two more methods from `RawSyntax` to the TokenView/LayoutView
ahoppen Aug 18, 2022
d1c23b7
Make layoutView and tokenView properties Optional
ahoppen Aug 18, 2022
66f4d6a
Move children accessors from RawSyntax to RawSyntaxLayoutView
ahoppen Aug 18, 2022
7b72402
Remove child(at:) and hasChild methods from RawSyntaxLayoutView
ahoppen Aug 18, 2022
68cd96e
Apply changes to new UnresolvedTernaryExprSyntax
ahoppen Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ let package = Package(
dependencies: ["_CSwiftSyntax"],
exclude: [
"Misc.swift.gyb",
"RawSyntaxNodes.swift.gyb",
"RawSyntaxValidation.swift.gyb",
"Raw/RawSyntaxNodes.swift.gyb",
"Raw/RawSyntaxValidation.swift.gyb",
"SyntaxAnyVisitor.swift.gyb",
"SyntaxBaseNodes.swift.gyb",
"SyntaxClassification.swift.gyb",
Expand Down
2 changes: 1 addition & 1 deletion Sources/SwiftSyntax/IncrementalParseTransition.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ public struct IncrementalParseLookup {
return true
}
if let nextToken = nextSibling.raw.firstToken(viewMode: .sourceAccurate) {
nextLeafNodeLength = nextToken.totalLength - nextToken.trailingTriviaLength
nextLeafNodeLength = nextToken.raw.totalLength - nextToken.trailingTriviaLength
}
}
let nodeAffectRange = ByteSourceRange(offset: node.position.utf8Offset,
Expand Down
0 .../SwiftSyntax/RawSyntax+CSwiftSyntax.swift → ...ftSyntax/Raw/RawSyntax+CSwiftSyntax.swift
View file
Open in desktop
File renamed without changes.
Loading