Split token and layout specific methods to specific views #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/rawsyntax-split
branch
2 times, most recently
from
5c8acc3 to
a06ff4c
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
pr/rawsyntax-split
branch
from
a06ff4c to
f36f3e6
Compare
|
@swift-ci Please test |
rintaro
approved these changes
Aug 18, 2022
…l file Also move all the Raw files into a `Raw` subdirectory. Guard token and layout specific functions on RawSyntax behind dedicated views.
This makes it clear at the call site that the node might not be a layout or token.
ahoppen
force-pushed
the
pr/rawsyntax-split
branch
from
f36f3e6 to
68cd96e
Compare
|
@swift-ci Please test |
This was referenced Aug 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it obvious when you are accessing properties that only exist on tokens or views.
Also shuffled the API a little bit (e.g. removing children accessors that weren’t providing real value).