Specify node names for diagnostics in gyb_syntax_support #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
Aug 30, 2022
|
|
||
| parameters = [ | ||
| 'name: "%s"' % node.syntax_kind, | ||
| 'nameForDiagnostics: "%s"' % node.name_for_diagnostics or 'nil' |
There was a problem hiding this comment.
Is this being evaluated as ('nameForDiagnostics: "%s"' % node.name_for_diagnostics) or 'nil'? They're all "None" rather than nil 😅 .
There was a problem hiding this comment.
Oh, that did actually get evaluate incorrectly and I didn’t catch it because I didn’t build generate-swift-syntax-builder locally.
Fixed it now.
bnbarham
approved these changes
Aug 30, 2022
ahoppen
force-pushed
the
ahoppen/node-name-for-diagnostic
branch
from
4f22d13 to
04e39fa
Compare
ahoppen
force-pushed
the
ahoppen/node-name-for-diagnostic
branch
from
04e39fa to
112e5d4
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces more meaningful, contextual diagnostics and removes a FIXME that we were maintaining node names for diagnostics in SwiftParser.