Skip to content

Improve doc comment of nodeTypeNameForDiagnostics #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Sep 9, 2022

As suggested in #736 (comment)

@ahoppen
Copy link
Member Author

ahoppen commented Sep 9, 2022

@swift-ci Please test

/// diagnostics. If the node itself has no diagnostic name (eg. it exists for
/// the syntax tree's structure), use the name of the enclosing parent node by
/// default.
/// Pass inherit: false to prevent this behavior, in which case `nil` will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Pass inherit: false to prevent this behavior, in which case `nil` will be
/// Pass `inherit: false` to prevent this behavior, in which case `nil` will be

@ahoppen ahoppen merged commit 23e54c1 into swiftlang:main Sep 20, 2022
@ahoppen ahoppen deleted the ahoppen/improve-doc-comment branch September 20, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants