Improve diagnostic message if unexpected tokens are found at the start of a layout node #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
approved these changes
Sep 8, 2022
…t of a layout node This helps us produce better error messages once we implement recovery in front of declarations.
ahoppen
force-pushed
the
ahoppen/unexpected-at-start-of-layout
branch
from
a633470 to
e605486
Compare
|
@swift-ci Please test |
bnbarham
reviewed
Sep 9, 2022
Comment on lines
+19
to
+24
| /// Return a name of this syntax node that can be used to describe it in | ||
| /// diagnostics. | ||
| /// Nodes that mostly exist for the syntax tree's structure and don't have a | ||
| /// correspondence in the source code that's meeingful to the user by default | ||
| /// use the name of the parent node that encloses it. Pass `false` to `inherit` | ||
| /// to prevent this name inheritance. |
There was a problem hiding this comment.
I know this is already merged, but FWIW there's meeingful + that sentence is a little hard to parse. Maybe:
Return the name of this syntax node to be used to describe it in diagnostics. If the node itself has no diagnostic name (eg. it exists for the syntax tree's structure), use the name of the enclosing parent node by default. Pass
inherit: falseto prevent this behavior, in which casenilwill be returned instead.
There was a problem hiding this comment.
Thanks for the suggestion. I put up a PR to incorporate the new description #760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us produce better error messages once we implement recovery in front of declarations.
Unfortunately, we don’t have a test case that exercises the new paths yet.