Pin SwiftSyntaxBuilder version for generate-swiftsyntaxbuilder #826
Conversation
ahoppen
force-pushed
the
ahoppen/pin-swiftsyntaxbuilder-version
branch
2 times, most recently
from
d3fba26 to
04cbd9e
Compare
Code-Generation/Package.swift
Outdated
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "SwiftSyntaxGeneration", |
There was a problem hiding this comment.
Should the package name match the folder name? For consistency, wdyt about naming the package (and the folder) in PascalCase, i.e. CodeGeneration without the hyphen?
There was a problem hiding this comment.
Good catch. I renamed it.
| "--gyb-only", | ||
| action="store_true", | ||
| help=""" | ||
| Only generate gyb templates (and not generate-swift-syntax-builder's templates) |
There was a problem hiding this comment.
I know this wasn't a change introduced in this PR, but I think Python doesn't automatically dedent multi-line strings like Swift, so we should probably use something like .strip() or textwrap.dedent to avoid ending up with strange formatting in the help output.
There was a problem hiding this comment.
Good idea. I’ll set up another PR for it.
There was a problem hiding this comment.
I just checked and these messages get automatically demented because we use argparse.RawDescriptionHelpFormatter.
There was a problem hiding this comment.
Ah interesting, didn't know about that, nice! 👍
ahoppen
force-pushed
the
ahoppen/pin-swiftsyntaxbuilder-version
branch
from
04cbd9e to
f6a4532
Compare
This resolves a bootstrapping issue that running `generate-swiftsyntaxbuilder` might modify `SwiftSyntaxBuilder`, which in turn makes it impossible to build and run `generate-swiftsyntaxbuilder`. Co-Authored-By: fwcd <[email protected]>
Since we pin a SwiftSyntaxBuilder version for generate-swiftsyntaxbuilder, we no longer need to perform gyb-generation in two phases.
ahoppen
force-pushed
the
ahoppen/pin-swiftsyntaxbuilder-version
branch
from
f6a4532 to
149604c
Compare
|
@swift-ci Please test |
This pretty much re-opens #580 on top of current
main.This resolves a bootstrapping issue that running
generate-swiftsyntaxbuildermight modifySwiftSyntaxBuilder, which in turn makes it impossible to build and rungenerate-swiftsyntaxbuilder.