Move gyb_syntax_support in swift-syntax from Sources/generate-swift-syntax-builder to Code-Generation #61226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/move-gyb-syntax-support
branch
2 times, most recently
from
7dad680 to
2c7ff9e
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/move-gyb-syntax-support
branch
from
2c7ff9e to
582f545
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/move-gyb-syntax-support
branch
from
582f545 to
245c0b1
Compare
|
@swift-ci Please smoke test |
CodaFi
reviewed
Sep 22, 2022
cmake/modules/AddSwift.cmake
Outdated
| @@ -6,7 +6,7 @@ include(SwiftAndroidSupport) | |||
| include(SwiftCXXUtils) | |||
|
|
|||
| function(_swift_gyb_target_sources target scope) | |||
| set(SWIFT_SYNTAX_GYB_SUPPORT_DIR "${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}/Sources/generate-swift-syntax-builder") | |||
| set(SWIFT_SYNTAX_GYB_SUPPORT_DIR "${SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE}") | |||
There was a problem hiding this comment.
We don’t need this variable
There was a problem hiding this comment.
I thought that it might useful to have it in case we move gyb_syntax_support again. But we can probably just re-introduce it if needed. And hopefully we don’t move that directory anymore.
…yntax-builder to Code-Generation
ahoppen
force-pushed
the
ahoppen/move-gyb-syntax-support
branch
from
245c0b1 to
3bb4d4d
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift-syntax#826