Skip to content

Roll Back ArgumentParser Dependency #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 21, 2022

This matches the version number found in the rest of the Swift projects and also matches update-checkout which is pinned to version 1.0.3.

This matches the version number found in the rest of the Swift projects
and also matches update-checkout which is pinned to version 1.0.3.
@CodaFi CodaFi requested a review from ahoppen as a code owner September 21, 2022 20:28
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 21, 2022

@swift-ci test

@CodaFi CodaFi merged commit 643f3de into swiftlang:main Sep 21, 2022
@CodaFi CodaFi deleted the dont-bring-me-down branch September 21, 2022 21:56
@jpsim
Copy link
Contributor

jpsim commented Sep 24, 2022

Is there a plan to update this? It'd be nice to allow projects that depend on SwiftSyntax and ArgumentParser to be able to be on the latest released versions of both.

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 24, 2022

I believe that this repository in particular can probably relax its upper bound on the argument parser to accommodate you.

My understanding is the general problem is keeping the Windows builders happy a la swiftlang/swift-driver#1106.

@jpsim
Copy link
Contributor

jpsim commented Sep 25, 2022

Yes either loosening the upper bound or decoupling the CLI targets from the library targets in this package could also work, since most consumers of the SwiftSyntax libraries won’t need its CLI targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants