Skip to content

Avoid Regex API availability check when no filter or skip flags have been passed #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2024
Merged

Avoid Regex API availability check when no filter or skip flags have been passed #410

merged 2 commits into from
May 9, 2024

Conversation

stmontgomery
Copy link
Contributor

Fix several test failures in SwiftPMTests when running on older Apple OS versions before Regex was added, which is due to unnecessarily checking whether that API is available. One example:

✘ Test "No --filter or --skip argument" recorded an issue at SwiftPMTests.swift:40:4: Caught error: The `--filter' option is not supported on this OS version.

In tests which do not involve --filter or --skip arguments, this check is unnecessary and can be avoided altogether.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added the bug 🪲 Something isn't working label May 9, 2024
@stmontgomery stmontgomery self-assigned this May 9, 2024
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

grynspan
grynspan reviewed May 9, 2024
View reviewed changes
grynspan
grynspan reviewed May 9, 2024
View reviewed changes
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery stmontgomery merged commit a1301c6 into swiftlang:main May 9, 2024
@stmontgomery stmontgomery deleted the filter-arg-evaluation branch May 9, 2024 16:00
@stmontgomery stmontgomery added the swiftpm-integration 📦 Swift Package Manager integration label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grynspan grynspan grynspan approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
bug 🪲 Something isn't working swiftpm-integration 📦 Swift Package Manager integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmontgomery @grynspan