Skip to content

Avoid Regex API availability check when no filter or skip flags have been passed #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Testing/EntryPoints/EntryPoint.swift
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,9 @@ public func configurationForEntryPoint(from args: __CommandLineArguments_v0) thr
// Filtering
var filters = [Configuration.TestFilter]()
func testFilter(forRegularExpressions regexes: [String]?, label: String, membership: Configuration.TestFilter.Membership) throws -> Configuration.TestFilter {
guard let regexes else {
guard let regexes, !regexes.isEmpty else {
// Return early if empty, even though the `reduce` logic below can handle
// this case, in order to avoid the `#available` guard.
return .unfiltered
}

Expand Down