Skip to content

build: ignore deprecation warnings on Windows #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

compnerd
Copy link
Member

Adjust the compile flags for TSCBasic on Windows. Avoid the separate
checks and addition of flags in favour of generator expressions.

Adjust the compile flags for TSCBasic on Windows.  Avoid the separate
checks and addition of flags in favour of generator expressions.
@compnerd
Copy link
Member Author

CC: @tomerd @neonichu @abertelrud

@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomerd
Copy link
Contributor

tomerd commented Aug 10, 2020

do we have windows CI for this?

@compnerd
Copy link
Member Author

Not yet, but the nighters do build t-s-c, as we bring up more pieces we can enable them.

@neonichu neonichu merged commit 25249a7 into swiftlang:master Aug 12, 2020
@compnerd compnerd deleted the deprecated branch August 12, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants