Skip to content

TSCBasic: avoid POSIX name on Windows for strdup #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

compnerd
Copy link
Member

THis generates a warning, so use the "portable" name _strdup instead.
This should be functionally identical.

THis generates a warning, so use the "portable" name `_strdup` instead.
This should be functionally identical.
@compnerd
Copy link
Member Author

CC: @tomerd @neonichu @abertelrud

@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomerd
Copy link
Contributor

tomerd commented Aug 10, 2020

#102 (comment)

@neonichu neonichu merged commit 154af99 into swiftlang:master Aug 10, 2020
@compnerd compnerd deleted the duplication branch August 10, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants