TSCLibc: add an implementation of mkdtemp for Windows
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an implementation of `mkdtemp` for Windows to accommodate swift-package-manager which uses this rather than Foundation.
|
@swift-ci please test |
tomerd
reviewed
Aug 11, 2020
| public func mkdtemp( | ||
| _ template: UnsafeMutablePointer<CChar>? | ||
| ) -> UnsafeMutablePointer<CChar>? { | ||
| fatalError("mkdtemp is unimplemented") |
There was a problem hiding this comment.
was this just not used before?
There was a problem hiding this comment.
It "was" in the sense that s-p-m never got to the point of building stuff previously. I've had this change laying around for ages (well had a version of it that worked well enough). Just draining changes that will allow s-p-m to get further :) I think that this might be better to implement using Foundation.
|
@compnerd please merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an implementation of
mkdtempfor Windows to accommodateswift-package-manager which uses this rather than Foundation.