un-deprecate AbsolutePath::appending(RelativePath) #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: concatinating rlative path to absolute path is a key API we should preserve it, but improve the implementation chnages: remove deprecation marker from AbsolutePath::appending(RelativePath) work to improve the implementation is tracked in swiftlang#336
tomerd
requested review from
aciidgh,
abertelrud,
neonichu and
friedbunny
as code owners
|
@swift-ci test |
neonichu
approved these changes
Jul 13, 2022
tomerd
added a commit
to tomerd/swift-tools-support-core
that referenced
this pull request
Jul 13, 2022
motivation: concatinating rlative path to absolute path is a key API we should preserve it, but improve the implementation chnages: remove deprecation marker from AbsolutePath::appending(RelativePath) work to improve the implementation is tracked in swiftlang#336
|
I thought that the plan was to undeprecate on 5.7 only and change the interface on main? |
tomerd
added a commit
that referenced
this pull request
Jul 13, 2022
motivation: concatinating rlative path to absolute path is a key API we should preserve it, but improve the implementation chnages: remove deprecation marker from AbsolutePath::appending(RelativePath) work to improve the implementation is tracked in #336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: concatinating rlative path to absolute path is a key API we should preserve it, but improve the implementation
chnages: remove deprecation marker from AbsolutePath::appending(RelativePath)
work to improve the implementation is tracked in #336