refactor windows path implementation out of UnixPath and into WindowsPath #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: every method on UnixPath has an #if os(Windows) changes: * define WindowsPath, peer to UnixPath * move all windows code to WindowsPath, and all POSIX code to UnixPath * set PathImpl type alias accordingly
tomerd
requested review from
aciidgh,
abertelrud,
neonichu and
friedbunny
as code owners
|
@swift-ci test |
tomerd
changed the title
compnerd
approved these changes
Jul 13, 2022
Sources/TSCBasic/Path.swift
Outdated
| let string: String | ||
|
|
||
| static let root = UNIXPath(string: "/") | ||
| static let root = WindowsPath(string: "/") |
There was a problem hiding this comment.
I think that this should be \.
Suggested change
| static let root = WindowsPath(string: "/") | |
| static let root = WindowsPath(string: "\\") |
Suggested change
| static let root = WindowsPath(string: "/") | |
| static let root = WindowsPath(string: "/") |
There was a problem hiding this comment.
I have not changed the logic here from the original code: https://github.com/apple/swift-tools-support-core/blob/main/Sources/TSCBasic/Path.swift#L473
|
We probably should ensure that this doesn't regress SPM ... at the very least, please do a cross-repo test for building the toolchain with this. |
neonichu
approved these changes
Jul 13, 2022
|
@compnerd yes I kicked one off: swiftlang/swift-package-manager#5661 |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: every method on UnixPath has an #if os(Windows)
changes: