Skip to content

Commit 99e98e6

Browse files
committed
[android] Remove XFAIL for tests that started passing.
These tests were disabled in #33500 (a0333a4) and #30390 (6ac04c6) because the optimizer did not seem to be working in Android ARMv7. At some moment between October 21st and October 30th something unbroke the tests. I have looked into the changes in the SILOptimizer directory, but I cannot pinpoint it to any of them in particular. It might be also changes introduced in LLVM.
1 parent 4e9d3a1 commit 99e98e6

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

test/SILOptimizer/let_properties_opts.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33

44
// REQUIRES: optimized_stdlib
55

6-
// See https://bugs.swift.org/browse/SR-12370
7-
// XFAIL: OS=linux-androideabi && CPU=armv7
8-
96
// Test propagation of non-static let properties with compile-time constant values.
107

118
// TODO: Once this optimization can remove the propagated fileprivate/internal let properties or

test/SILOptimizer/opt-remark-generator.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-swiftc_driver -O -Rpass-missed=sil-opt-remark-gen -Xllvm -sil-disable-pass=FunctionSignatureOpts -emit-sil %s -o /dev/null -Xfrontend -verify
22
// REQUIRES: optimized_stdlib,swift_stdlib_no_asserts
33

4-
// XFAIL: OS=linux-androideabi && CPU=armv7
5-
64
public class Klass {}
75

86
// TODO: Change global related code to be implicit/autogenerated (as

0 commit comments

Comments
 (0)