[android][armv7] Mark let_properties_opts.swift as XFAIL. #30390
Conversation
|
Is there any other 32 bit platform? (Specially one that Apple cares about?) @swift-ci please test |
|
Build failed |
|
ARMv7k is 32-bits, definitely is important |
|
And seems that the iPhone Simulator i386 as well. I will have to come with another approach or figure out why the inlining is not happening in Android ARMv7. |
Looks like Android ARMv7 is not inline storeBytes so the test were failing. Mark the test as XFAIL and open a bug in the tracker to keep the CI green for the moment.
drodriguez
force-pushed
the
android-let-properties-opts-armv7
branch
from
d319a05 to
6ac04c6
Compare
drodriguez
changed the title
|
I don't think I can fix this by myself in my free time. I opened https://bugs.swift.org/browse/SR-12370 with a little bit more information, and I have xfailed this test to keep CI going on. Looks like many optimizations are not taken in @swift-ci please test |
|
Build failed |
|
@swift-ci test macOS |
|
Build failed |
|
I can't understand why this failed OSX testing, maybe it was spurioius. |
|
@swift-ci test OS X |
|
Thanks for restarting the CI! Hopefully the Android CI will get green again. |
These tests were disabled in swiftlang#33500 (a0333a4) and swiftlang#30390 (6ac04c6) because the optimizer did not seem to be working in Android ARMv7. At some moment between October 21st and October 30th something unbroke the tests. I have looked into the changes in the SILOptimizer directory, but I cannot pinpoint it to any of them in particular. It might be also changes introduced in LLVM.
Looks like Android ARMv7 is not inline storeBytes so the test were
failing. Mark the test as XFAIL and open a bug in the tracker to keep
the CI green for the moment.
The problem appeared after https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/5667/ (probably 5668, but it is not longer available). One can see the error in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/5691/. From running the code, it looks like in ARMv7 (32 bits) the code is not inlined, so the generated SIL is different.