[android] XFAIL opt-remark-generator.swift in ARMv7 #33500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android ARMv7 doesn't seem to simplify the remarks from Optional<SubKlass> to just SubKlass, while other platforms do. I did not find any clues in swiftlang#33171 what it might be happening, so XFAIL the test to avoid a failing build.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macos platform |
|
Build failed |
|
@swift-ci please test macos platform |
|
@drodriguez if we aren't simplifying this, it is sort of weird. Maybe file an SR? |
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Nov 3, 2020
These tests were disabled in swiftlang#33500 (a0333a4) and swiftlang#30390 (6ac04c6) because the optimizer did not seem to be working in Android ARMv7. At some moment between October 21st and October 30th something unbroke the tests. I have looked into the changes in the SILOptimizer directory, but I cannot pinpoint it to any of them in particular. It might be also changes introduced in LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android ARMv7 doesn't seem to simplify the remarks from
Optional to just SubKlass, while other platforms do.
I did not find any clues in #33171 what it might be happening, so XFAIL
the test to avoid a failing build.