Promote a bunch of Swift 3 compatibility access warnings to errors. #10086
Conversation
|
@swift-ci Please test |
This was done back in Swift 3.0.1 or 3.0.2. Let's finally make them errors in Swift 4! I also fixed up a number of '%error' entries in diagnostics that can actually happen in invalid code. These are the ones that were already present in the warnings.
jrose-apple
force-pushed
the
access-denied
branch
from
6a1b958 to
84446c8
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Well, the text changed too, so I don't feel so bad. Thanks, Harlan! |
|
@jtbandes Might also want to get in on this after his last big push for trapping in diagnostics. |
|
Can we add test cases for the “in this context” versions? |
|
(The point of %error was to crash so we could catch it in validation tests, but if these could happen, I guess they weren’t tested properly 😉) |
|
Any places where they could happen before would always fall into the "warning" case; now that's no longer true. Yes, I can add more test cases, though maybe as a follow-up. (They only come up when you violate the model once and then reference that declaration.) |
|
@swift-ci please test (borrowing this PR to test a test infrastructure issue) |
…wiftlang#10086) This was done back in Swift 3.0.1 or 3.0.2. Let's finally make them errors in Swift 4! I also fixed up a number of '%error' entries in diagnostics that can actually happen in invalid code. These are the ones that were already present in the warnings.
This was done back in Swift 3.0.1 or 3.0.2. Let's finally make them errors in Swift 4!
I also fixed up a number of
%errorentries in diagnostics that can actually happen in invalid code. These are the ones that were already present in the warnings.