Escalate the warning about the "== Self" type soundness hole to an error #10319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
|
@DougGregor ProcedureKit is a part of the source compatibility suite now. It will likely start failing now that you turned this warning into an error. We may need to XFAIL ProcedureKit until they fix it. |
|
Good point. |
DougGregor
force-pushed
the
escalate-type-soundness-warning
branch
from
25b1e81 to
b818c33
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
…ror. Swift 3 had a type soundness hole in protocol conformance checking where the requirement contained an "== Self" constraint and the witness was a member of a non-final class. We previously closed the type soundness hole in PR swiftlang#9830, but left it as a warning in Swift 3 compatibility mode. Escalate that warning to an error. The optimizers break due to this type soundness hole, and of course it can lead to other runtime breakage because it violates the type system. Fixes rdar://problem/28601761.
|
Too many things going on in one tree. |
|
@swift-ci please smoke test and merge |
DougGregor
force-pushed
the
escalate-type-soundness-warning
branch
from
b818c33 to
8b80681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 3 had a type soundness hole in protocol conformance checking
where the requirement contained an
== Selfconstraint and thewitness was a member of a non-final class. We previously closed the
type soundness hole in PR #9830, but left it as a warning in Swift 3
compatibility mode.
Escalate that warning to an error. The optimizers break due to this
type soundness hole, and of course it can lead to other runtime
breakage because it violates the type system.
Fixes rdar://problem/28601761.