Skip to content

[Shepherd] build: create and use a wrapper for add_llvm_tool_symlink #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jun 16, 2017

Rebased and updated #6053

Introduce a new function `add_swift_tool_symlink`.  Use this instead of the
`add_llvm_tool_symlink` and `install_in_swift_component`.  This mimics the
behaviour in clang as well as the general pattern of renaming the functions from
the LLVM build infrastructure.
@CodaFi CodaFi requested a review from hughbe June 16, 2017 22:59
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 16, 2017

@swift-ci please clean smoke test

@jrose-apple jrose-apple requested a review from llvm-beanz June 16, 2017 23:27
Copy link
Contributor

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 17, 2017

⛵️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants