Sema: missing switch case fixits should print payload names explicitly instead of printing underscores. rdar://32121806 #10409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion, if the location cannot be further refined to other kind, e.g. a reference. rdar://32749670
This reverts commit 0e715ee.
…n expression, if the location cannot be further refined to other kind, e.g. a reference. rdar://32749670" This reverts commit d6091d5.
…y instead of printing underscores. rdar://32121806
|
@swift-ci please smoke test |
CodaFi
reviewed
Jun 20, 2017
lib/Sema/TypeCheckSwitchStmt.cpp
Outdated
|
|
||
| // This is for type space only to help us print meaningful name, e.g., | ||
| // tuple element name in fixits. | ||
| Identifier NameForPrinting; |
There was a problem hiding this comment.
You probably could reuse the Head for this and write a getName() accessor that does a type check like the others.
There was a problem hiding this comment.
So Head is not used at all for type space?
There was a problem hiding this comment.
Nope. I assumed nobody would need it - 's why it prints as an underscore.
There was a problem hiding this comment.
Sounds good, will change.
|
@swift-ci please smoke test |
CodaFi
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.