[4.0] Sema: missing switch case fixits should print payload names explicitly instead of printing underscores. rdar://32121806 #10417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The fixit for missing enum cases used to insert
_for associated values of enum cases, which is not informative enough. As a consequence, it may create an extra step of jump to definition to figure out what the associate values signify. This patch changes "_" to using the actual payload name, e.g. "let X" in the content fixits create.Reviewed by: @CodaFi
Scope: Compiler Fixit
Radar: rdar://32121806
Risk: Low
Testing: Existing test updated