Skip to content

[overlay] Rename scheduleOneShot and scheduleRepeating #10598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jun 26, 2017

rdar://29587696

@moiseev
Copy link
Contributor Author

moiseev commented Jun 26, 2017

@swift-ci Please test

@moiseev moiseev merged commit 59c5e56 into swiftlang:master Jun 27, 2017
@moiseev moiseev deleted the dispatch-oneshot branch June 27, 2017 16:44
@ianpartridge
Copy link
Contributor

Hi @moiseev this change needs making in swift-corelibs-libdispatch too. Are you going to do that or would you like me to open a PR?

@moiseev
Copy link
Contributor Author

moiseev commented Jul 11, 2017

Good catch, @ianpartridge ! /cc @ktopley-apple.

@moiseev
Copy link
Contributor Author

moiseev commented Jul 11, 2017

@ianpartridge, normally changes would be applied to both the overlay here as well as xcorelibs-lilbdispatch, but for some reason this change was not. Turns out there is work going on that will make them in sync again. So, yes, this change will be applied to xcorelibs by the Dispatch team. Thanks for pointing it out!

@ianpartridge
Copy link
Contributor

ianpartridge commented Jul 11, 2017

OK @moiseev - I'll look out for the commit on swift-corelibs-libdispatch. Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants