Skip to content

[swift-4.0-branch][overlay] Rename scheduleOneShot and scheduleRepeating #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jun 27, 2017

  • Explanation: This change deprecates several methods of the DispatchSourceTimer struct, replacing them with methods that have more meaningful names. It also introduces the enumeration case DispatchTimeInterval.never, which can be used to specify that a timer should never fire or never repeat.
  • Scope of Issue: This is not a source-breaking change. The only effect on existing code is that uses of the deprecated methods will be flagged at compile time.
  • Risk: Since the existing methods remain and their code is almost unmodified, this is a very low-risk change.
  • Reviewed By: Daniel Steffen
  • Testing: There are tests in the Dispatch test suite that cover this code change.
  • Directions for QA: N/A
  • Radar: rdar://problem/32991313

rdar://29587696
(cherry picked from commit eaf20b2)
@moiseev
Copy link
Contributor Author

moiseev commented Jun 27, 2017

Cherrypicked from #10598

@moiseev moiseev changed the title [overlay] Rename scheduleOneShot and scheduleRepeating [swift-4.0-branch][overlay] Rename scheduleOneShot and scheduleRepeating Jun 27, 2017
@moiseev
Copy link
Contributor Author

moiseev commented Jun 27, 2017

@swift-ci Please test

@moiseev moiseev merged commit 396c016 into swiftlang:swift-4.0-branch Jun 27, 2017
@moiseev moiseev deleted the dispatch-oneshot-4 branch June 27, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant