Fix EncodingError/DecodingError bridging to NSError #10674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomNSError conformance only enables bridging for types which are declared in the same module as the conformance. Since we cannot use CustomNSError in the stdlib, we need to use other entry points to allow this bridging.
|
@swift-ci Please test macOS |
|
@swift-ci Please smoke test Linux |
|
Whoops, I just realized I'd pushed the wrong version of this. Rebasing and repushing momentarily. |
|
Actually, going to reopen this as a new PR with a different set of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Fixes bridging of these error types to
NSErrorandLocalizedError.CustomNSErrorconformance only enables bridging for types which are declared in the same module as the conformance. Since we cannot useCustomNSErrorin the stdlib, we need to use other entry points to allow this bridging.