EncodingError/DecodingError bridging fixes and conveniences #10685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 28, 2017 14:31
Some errors are caused by others — this allows us to expose the underlying problem.
CustomNSError briding only works when the CustomNSError conformance is in the same module as the original error declaration. We need to sink these down into the standard library.
DecodingError.dataCorrupted is an error most commonly thrown from user code. We can expose conveniences to more easily throw .dataCorrupted errors.
If JSONSerialization or PropertyListSerialization throw errors during encoding or decoding, the error should be exposed as an EncodingError or DecodingError
|
This is the correct version which should work on Linux as well. |
|
@swift-ci Please test |
phausler
approved these changes
Jun 29, 2017
|
|
||
| return userInfo as AnyObject | ||
| #else | ||
| return nil |
There was a problem hiding this comment.
can we have a callback here to hook a return for swift-corelibs-foundation?
There was a problem hiding this comment.
As mentioned in person, since we don't have error bridging on Linux anyway, nothing would hit that callback, unfortunately. I think this should be one of our focus points for the next release, and once we have more infrastructure in place, we should definitely put a hook in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
As laid out in a proposed update to SE-0166 and SE-0167, there are
EncodingError/DecodingErrorupdates that we wanted to introduce to the Codable API. This implements the remainder of those updates which had not yet been implemented:underlyingErrorexposition onEncodingErrorandDecodingError.dataCorruptedconveniences for user codeNSErrorThis subsumes #10674.