[4.0] Remove overlapping exclusive accesses in encoders #10821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{JSON,Plist}{Encoder,Decoder} had overlapping accesses which were supposed to be mutually exclusive in their `with(pushedKey:)` methods.
Removes those methods and the overlapping accesses.
|
@swift-ci Please test macOS |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
itaiferber
deleted the
4.0-encoders-eliminate-overlapping-exclusive-accesses
branch
devincoughlin
added a commit
to devincoughlin/swift-corelibs-foundation
that referenced
this pull request
Apr 13, 2018
Bring in changes from the Swift overlays to avoid exclusivity warnings. These changes come from: swiftlang/swift#10821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Cherry-picks #10819 to
swift-4.0-branch.Explanation: {JSON,Plist}{Encoder,Decoder} had overlapping accesses which were supposed to be mutually exclusive in their
with(pushedKey:)methods. This Removes those methods and the overlapping accesses.Scope: Affects anyone trying to use these classes as we're not invoking undefined behavior.
Radar: rdar://problem/33146339
Risk: Low
Testing: All existing unit test pass; warnings for this no longer produced.