Instructions to install Ninja updated. #10858
Conversation
One sentence was not syntactically correct, I have replaced it to make the installation process clearer.
README.md
Outdated
| it next to the other projects and it will be bootstrapped automatically: | ||
| for building Swift and is the default configuration generated by CMake. [Pre-built | ||
| packages](https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages) | ||
| are available for macOS and Linux distributions, you can also clone Ninja |
There was a problem hiding this comment.
are available for macOS and Linux distributions, you can also clone Ninja
Comma splice
|
|
||
| ##### Build from source |
There was a problem hiding this comment.
Why did you remove this header?
There was a problem hiding this comment.
The line above, "You can also clone Ninja next to the other projects and it will be bootstrapped automatically:", already states that we are going to give instructions to build Ninja from source.
The line removed was also smaller than the next lines "Via SSH" and "Via HTTPS" when reading the README, which was quite strange.
As this is quite a subjective change, I can revert it if my arguments do not convince you.
There was a problem hiding this comment.
I see. On a second read-through I quite like this. Thanks ✨
|
Thanks for putting up with me ⛵️ |
|
@swift-ci please smoke test |
One sentence was not syntactically correct, I have replaced it to make the installation process clearer.