Skip to content

Instructions to install Ninja updated. #10858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2017
Merged

Instructions to install Ninja updated. #10858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca5d449
Instructions to install Ninja updated.
armandgrillet Jul 10, 2017
91b132f
Comma splice removed.
armandgrillet Jul 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ command line tools to your `PATH`:

#### Ninja
[Ninja](https://ninja-build.org) is the current recommended build system
for building Swift and is the default configuration generated by CMake. If
you're on macOS or don't install it as part of your Linux distribution, clone
it next to the other projects and it will be bootstrapped automatically:
for building Swift and is the default configuration generated by CMake. [Pre-built
packages](https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages)
are available for macOS and Linux distributions. You can also clone Ninja
next to the other projects and it will be bootstrapped automatically:

##### Build from source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above, "You can also clone Ninja next to the other projects and it will be bootstrapped automatically:", already states that we are going to give instructions to build Ninja from source.

The line removed was also smaller than the next lines "Via SSH" and "Via HTTPS" when reading the README, which was quite strange.

As this is quite a subjective change, I can revert it if my arguments do not convince you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. On a second read-through I quite like this. Thanks ✨

**Via HTTPS**

git clone https://github.com/ninja-build/ninja.git && cd ninja
Expand Down