TBD: includes all symbols from a full build and test #10861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack around IRGen's inadequacies, for the moment.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test Linux platform |
These were accidentally non-static.
These were accidentally left as `extern` rather than the correct `static` or `static inline` (etc.).
… linkage. Previously this would mean that specialization of a public function are public, which is incorrect.
|
@swift-ci Please smoke test |
huonw
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test. |
|
@swift-ci Please clean smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this somewhat of a hack, every test under
-tresults in TBD files that include all the actual symbols, plus some extras.Being forced to include the internal materializeForSet closure is very ugly, but I'm not sure of an alternative at the moment, since it is serialized and private, which means IRGen promotes it to public. (rdar://problem/32254581)