[4.0] TBD including all files from a full build. #11136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only top-level globals in the main file that do not have
accessors, something like class Foo { static var x = 0 } has them no
matter where it is.
Fixes rdar://problem/32391290 .
This is a vast overestimate, but is better than missing some. rdar://problem/32254773
|
@swift-ci Please test. |
…ivate. If the closure is serialized, it needs to be shared.
These were accidentally non-static.
These were accidentally left as `extern` rather than the correct `static` or `static inline` (etc.).
… linkage. Previously this would mean that specialization of a public function are public, which is incorrect.
huonw
force-pushed
the
symbol-list-10-4.0
branch
from
1d04bc9 to
e1e48ab
Compare
|
@swift-ci Please test. @slavapestov could you review this for 4.0? (It includes the proper materializeForSet closure change.) |
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10861 , #10724 , and #11142 .
Explanation: TBDGen now includes all the exported symbols encountered while building the standard library and test suite.
Scope: Future users of TBD files, as there's no functionality change outside of it.
Radar: rdar://problem/32252869 and its subtasks.
Risk: Low: the only changes outside of TBDGen are tightening the linkage of some symbols, which people shouldn't be relying on.
Testing: CI and local testing with TBD validation turned on by default (which this PR doesn't include, as that could break user's build).