[4.0] IRGen: Make sure to use the C function type's alignment for indirect byval arguments #10932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irect byval arguments rdar://33242303 * Fix abitypes.swift test case * Use the max of abi alignment and swift's type alignment
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://33242303
• Explanation: We emit the wrong alignment attribute for indirect by value parameters in C functions called from Swift. This gets exposed by the merge function pass which merges functions and notices mismatching alignments. But it has correctness implications if the LLVM backend relies on the alignment for optimization or code emission.
• Scope of Issue: Correctness and crash
• Origination: I believe this issue has always been there
• Risk: Low. The IR generator now emits the proper alignment attribute on the function call and the alloca instruction that it generates for the indirect parameter passing.
• Reviewed By: John McCall