[4.0] IRGen: Fix test case only on x86-64 do we use indirect byval passing #11036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing rdar://33376164
|
@swift-ci Please test |
|
@swift-ci Please test linux |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: In the fix for rdar://33242303 / #10932 I added a test case that only succeeds on x86_64 platforms because it checks for the alignment of indirect byval parameters which we don’t emit on arm64. The test is written in a way that did not add the x86_64 target to the command line and would therefore fail on arm64.
• Scope of Issue: Failing test case because the test case is not narrow enough
• Origination: Recently introduced
• Risk: Low. This is a fix to a test case.
• Testing: The test case was fixed and should no longer fail during regression tests running on non x86_64 archs
rdar://33376164