Skip to content

[swift-4.0-branch][overlay] Add back INSetProfileInCarIntent.defaultProfile for compatibliity #11176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 25, 2017

  • Explanation: Adds back mistakenly deleted defaultProfile property for INSetProfileInCarIntent
  • Scope of Issue: Reinstates API backward compatibility
  • Risk: Minimal
  • Reviewed By: Max Moiseev
  • Testing: Automated test suite + a dedicated test case
  • Directions for QA: N/A
  • Radar: rdar://problem/33457609

@moiseev
Copy link
Contributor Author

moiseev commented Jul 25, 2017

@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Jul 25, 2017

Similar to #11175

…ibliity

<rdar://problem/33457609>

(cherry picked from commit 936a79cbf2eee87f03000ad570b1db6db1e10d10)
@moiseev moiseev force-pushed the missing-default-profile-4 branch from 7f84708 to 631dc2c Compare July 25, 2017 22:32
@moiseev
Copy link
Contributor Author

moiseev commented Jul 25, 2017

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 7f84708365236425df570f285382df43d6ec17c8
Test requested by - @moiseev

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 7f84708365236425df570f285382df43d6ec17c8
Test requested by - @moiseev

@moiseev moiseev merged commit 0e49ffd into swiftlang:swift-4.0-branch Jul 26, 2017
@moiseev moiseev deleted the missing-default-profile-4 branch July 26, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants