[4.0] [Serialization] Make requirement signature conformance loading lazy. #11661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the original commit was expected to have no effective impact, it turned out to actually solve some circularity issues after all involving protocols that inherit from other protocols. It should be a mild compile-time win as well in cases where the requirement signature is not needed at all. Test in subsequent commit. https://bugs.swift.org/browse/SR-5191 / rdar://problem/33804554 (cherry picked from commit 897effe)
…1685) This was fixed by 897effe, which I had originally thought would be a no-functionality-change commit because it just made things lazier. Turns out requirement signature deserialization can result in circularity with sufficiently cross-referential conformances. This isn't exactly a reduced test case because it still depends on subclassing NSObject, which probably means there are hidden dependencies on conforming to standard library protocols. But it's better than nothing. https://bugs.swift.org/browse/SR-5191
jrose-apple
force-pushed
the
4.0-lazy-signature-deserialization
branch
from
1b6f446 to
b38500b
Compare
|
@DougGregor, mind re-reviewing this since it's been a while since the original commit went in? @swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
It looks like everything passed and then Jenkins choked right at the end. But compute is cheap during the off season, so… @swift-ci Please test macOS |
|
Approved by Ted via email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.