[SILOptimizer] Handle a missing case in DataflowDiagnostics.cpp #11765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
reviewed
Sep 5, 2017
| struct S {} | ||
| extension S:ExpressibleByStringLiteral { | ||
| init!(stringLiteral:String) { | ||
| } // expected-error {{missing return in a function expected to return 'S!'}} |
There was a problem hiding this comment.
The real error is that we're missing a self.init delegation or self assignment, but I guess before we weren't diagnosing anything at all here?
There was a problem hiding this comment.
We were crashing with missing case before.
|
@graydon Next time can you add more context to the commit message on what the crash was? If I didn't have access to radar and I didn't see your comment, I would be very confuzzled = (. |
|
@gottesmm oh yeah, good point, sorry! |
|
@graydon No worries! |
graydon
deleted the
rdar-34111449-missing-case-in-SILOptimizer-dataflow-diagnostics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix for rdar://34111449