Fix wrong missing-return error message for an initializer returning an implicitly unwrapped optional #14272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n implicitly unwrapped optional The problem was that the unreachable instruction after the IUO unwrapping error call was interpreted as missing-return-unreachable. rdar://problem/36611041
|
@swift-ci smoke test |
eeckstein
commented
Jan 30, 2018
| @@ -97,7 +97,7 @@ func whileLoop(flag: Bool) -> Int { | |||
| struct S {} | |||
| extension S:ExpressibleByStringLiteral { | |||
| init!(stringLiteral:String) { | |||
| } // expected-error {{missing return in a function expected to return 'S!'}} | |||
| } // no error | |||
There was a problem hiding this comment.
@eeckstein Perhaps! I have no idea whether an IUO initializer with no body is legal, I was mainly concerned with making it stop crashing in #11765 by handling the case, and the existing diagnostic seemed to fit my understanding of the meaning of an IUO initializer with no body. But by all means confirm with someone who knows IUO semantics better than me.
There was a problem hiding this comment.
Returning successfully (i.e. a non-optional, properly-initialized S) would be the correct semantics.
There was a problem hiding this comment.
Yes, it returns an S (implicitly, not with a return statement)
graydon
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the unreachable instruction after the IUO unwrapping error call was interpreted as missing-return-unreachable.
rdar://problem/36611041