Skip to content

Reworking ClangImporter to not depend on Sema, part 4 #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2017
Merged

Reworking ClangImporter to not depend on Sema, part 4 #11873

merged 5 commits into from
Sep 13, 2017

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Sep 12, 2017 •
edited
Loading

Follow-up to #11812 which ensures that imported conformances all get signature conformances after the type checker has been torn down.

@slavapestov slavapestov force-pushed the divorce-clang-importer-from-sema-part-4 branch 2 times, most recently from 05b4f0d to d884914 Compare September 12, 2017 23:32
@slavapestov slavapestov force-pushed the divorce-clang-importer-from-sema-part-4 branch from d884914 to 472ea7f Compare September 12, 2017 23:38
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d88491498b54dd4d7857e524f8a3d5f9311461c0

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

1 similar comment
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov mentioned this pull request Sep 13, 2017
Merged
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 472ea7f

@slavapestov
Copy link
Contributor Author

This isn't my fault, and the Linux smoke test passed, so I'm going to merge:

Could not update commit status of the Pull Request on GitHub.
org.kohsuke.github.HttpException: Server returned HTTP response code: -1, message: 'null' for URL: https://api.github.com/repos/apple/swift/statuses/472ea7f1a04a2fa743afe786758079ea39038385
	at org.kohsuke.github.Requester.parse(Requester.java:622)
	at org.kohsuke.github.Requester.parse(Requester.java:620)
	at org.kohsuke.github.Requester.parse(Requester.java:620)
	at org.kohsuke.github.Requester.parse(Requester.java:584)
	at org.kohsuke.github.Requester._to(Requester.java:264)
	at org.kohsuke.github.Requester.to(Requester.java:226)
	at org.kohsuke.github.GHRepository.createCommitStatus(GHRepository.java:1000)

@slavapestov slavapestov merged commit 8998ff5 into swiftlang:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @swift-ci