Reworking ClangImporter to not depend on Sema, part 5 #11890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
changed the title
slavapestov
force-pushed
the
divorce-clang-importer-from-sema-part-5
branch
from
7bc212a to
0c6a3b8
Compare
There was some duplicate code for adding protocols to inheritance clauses and constructing the SynthesizedProtocolAttrs that indicate a conformance should have a LazyConformanceLoader. Clean this up to make it less error-prone. NFC for now, until further changes land.
slavapestov
force-pushed
the
divorce-clang-importer-from-sema-part-5
branch
from
0c6a3b8 to
ae5d6fd
Compare
slavapestov
changed the title
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11873 which moves
resolveKnownTypeWitness()from the AST to the ClangImporter, and makes it the canonical way of resolving associated types of imported conformances, even before the type checker is torn down.Unfortunately we still rely on the type checker to resolve the
RawValueassociated type in someRawRepresentableconformances. I think there's a logic error in ConformanceLookupTable that was previously not visible, but I haven't figured it out yet.