Re-apply "SIL: Remove special meaning for @_semantics("stdlib_binary_… #12275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
This broke stuff before. A smoke test is not sufficient. @swift-ci Please clean test |
|
(he says, wearing his build czar hat) |
|
And I've confirmed locally that the revert fixes things. |
|
Can you send me a failing build log? PR testing doesn't build StdlibUnittest with -sil-serialize-all, only some presets do that. It was put in place originally to improve optimizer test coverage by a bit, but it blows up build time. I don't think we're losing much by removing that. |
|
If the stdlib and perf teams are okay with the loss of coverage then we're fine, but please hold off on removing stdlib_binary_only until -sil-serialize-all is actually gone (Roman's patch). |
…only")" With -sil-serialize-all gone, this no longer means anything; just don't declare the function as @_inlineable instead. Fixes <rdar://problem/34564380>.
slavapestov
force-pushed
the
reapply-stdlib-binary-only
branch
from
dcf980b to
2e2b9dd
Compare
|
@swift-ci Please smoke test |
|
This has been merged into #12256, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…only")"
With -sil-serialize-all gone, this no longer means anything; just
don't declare the function as @_inlineable instead.
Fixes rdar://problem/34564380.